[libnftnl PATCH] src: cleanup in mxml and jansson regarding set_id parsing

[Arturo Borrero Gonzalez]

jansson.c: In function 'nft_jansson_expr_parse':
jansson.c:212:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
In file included from jansson.c:10:0:
./internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
jansson.c:195:18: warning: unused variable 'set_cur' [-Wunused-variable]
mxml.c: In function 'nft_mxml_expr_parse':
mxml.c:97:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
In file included from mxml.c:12:0:
internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
mxml.c:68:18: warning: unused variable 'set_cur' [-Wunused-variable]

Spotted with: gcc (Debian 4.7.2-5) 4.7.2

Signed-off-by: Arturo Borrero Gonzalez <***@gmail.com>
---
src/jansson.c | 4 ++--
src/mxml.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/jansson.c b/src/jansson.c
index 728de12..4c7968a 100644
--- a/src/jansson.c
+++ b/src/jansson.c
@@ -192,8 +192,8 @@ struct nft_rule_expr *nft_jansson_expr_parse(json_t *root,
{
struct nft_rule_expr *e;
const char *type;
- struct nft_set *set_cur = NULL;
- int ret, set_id;
+ uint32_t set_id;
+ int ret;

type = nft_jansson_parse_str(root, "type", err);
if (type == NULL)
diff --git a/src/mxml.c b/src/mxml.c
index 22d482f..a97d380 100644
--- a/src/mxml.c
+++ b/src/mxml.c
@@ -65,8 +65,8 @@ struct nft_rule_expr *nft_mxml_expr_parse(mxml_node_t *node,
struct nft_rule_expr *e;
const char *expr_name;
char *xml_text;
- struct nft_set *set_cur = NULL;
- int ret, set_id;
+ uint32_t set_id;
+ int ret;

expr_name = mxmlElementGetAttr(node, "type");
if (expr_name == NULL) {

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Pablo Neira Ayuso]

Post by Arturo Borrero Gonzalez
jansson.c:212:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
./internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
jansson.c:195:18: warning: unused variable 'set_cur' [-Wunused-variable]
mxml.c:97:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
mxml.c:68:18: warning: unused variable 'set_cur' [-Wunused-variable]

Oops, thanks Arturo.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html